Led matrix undo stack fix #89
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying review-pxt with
|
| Latest commit: |
0f21334
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b5eb7a4.review-pxt.pages.dev |
| Branch Preview URL: | https://led-matrix-undo-stack.review-pxt.pages.dev |
…10772) Co-authored-by: Richard Knoll <[email protected]>
…screen minisim (microsoft#10773) Co-authored-by: Richard Knoll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LED matrix was firing multiple redundant change events when the user interacted with it. Particularly bad was when the mousemove event fired multiple times over the same LED, triggering change events. This fix tests for an actual change in state and guards against firing additional events.
Before
Screen.Recording.2025-07-17.at.15.53.23.mov
After
Screen.Recording.2025-07-17.at.15.50.31.mov